eschutho commented on code in PR #35800:
URL: https://github.com/apache/superset/pull/35800#discussion_r2483002903
##########
superset/commands/report/execute.py:
##########
@@ -752,14 +767,21 @@ def next(self) -> None:
return
self.send()
self.update_report_schedule_and_log(ReportState.SUCCESS)
+ except ReportScheduleUnexpectedError:
+ # Don't try to log again if logging itself failed
+ raise
except (SupersetErrorsException, Exception) as first_ex:
error_message = str(first_ex)
if isinstance(first_ex, SupersetErrorsException):
error_message = ";".join([error.message for error in
first_ex.errors])
- self.update_report_schedule_and_log(
- ReportState.ERROR, error_message=error_message
- )
+ try:
Review Comment:
Thanks @sadpandajoe. Do you want to run codex again on these changes now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
