sadpandajoe commented on code in PR #35800:
URL: https://github.com/apache/superset/pull/35800#discussion_r2475478215
##########
superset/commands/report/execute.py:
##########
@@ -850,9 +890,21 @@ def next(self) -> None:
self.send()
self.update_report_schedule_and_log(ReportState.SUCCESS)
except Exception as ex: # pylint: disable=broad-except
- self.update_report_schedule_and_log(
- ReportState.ERROR, error_message=str(ex)
- )
+ try:
+ self.update_report_schedule_and_log(
+ ReportState.ERROR, error_message=str(ex)
+ )
+ except ReportScheduleUnexpectedError:
+ # Logging failed (likely StaleDataError), but we still want to
+ # raise the original error so the root cause remains visible
+ logger.warning(
+ "Failed to log error for report schedule %s due to
database issue",
+ self._report_schedule.id,
+ exc_info=True,
+ )
+ # Re-raise the original exception, not the logging failure
+ raise ex from None
Review Comment:
The same raise ex from None pattern and will likewise strip the wrapped
StaleDataError; preserving the cause here is important for debugging reports
that are deleted mid-run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
