msyavuz commented on code in PR #36854:
URL: https://github.com/apache/superset/pull/36854#discussion_r2652406493


##########
superset-frontend/src/features/databases/DatabaseModal/index.test.tsx:
##########
@@ -1585,6 +1585,87 @@ describe('DatabaseModal', () => {
   });
 });
 
+test('handleChangeWithValidation function clears validation errors when 
called', () => {

Review Comment:
   Testing user behaviour here is much more complex so i went with just testing 
the implementation. Otherwise we need to create e2e tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to