EnxDev commented on PR #36854: URL: https://github.com/apache/superset/pull/36854#issuecomment-3701913125
> > LGTM! I’m just wondering whether we should also add the isValidating prop here, similar to the Postgres database connection, which shows a loading spinner inside the field while validation is in progress. > > Validation here works after user clicks connect (for the Display Name field). So the loading spinner inside the input doesn't happen I might be missing something, but as shown in the video, in both cases the validation is triggered when clicking outside the field. From the moment validation starts to when the “Connect” button becomes enabled, there’s a short delay. I thought it might be useful to provide some loading feedback so users understand that the field is being validated. https://github.com/user-attachments/assets/39550cb2-f46e-4fdc-aaa7-8baad0ff2833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
