msyavuz commented on PR #36854: URL: https://github.com/apache/superset/pull/36854#issuecomment-3701477005
> LGTM! I’m just wondering whether we should also add the isValidating prop here, similar to the Postgres database connection, which shows a loading spinner inside the field while validation is in progress. Validation here works after user clicks connect (for the Display Name field). So the loading spinner inside the input doesn't happen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
