EnxDev commented on PR #36854: URL: https://github.com/apache/superset/pull/36854#issuecomment-3702492109
> > > I might be missing something, but as shown in the video, in both cases the validation is triggered when clicking outside the field. > > > > > > > From the moment validation starts to when the “Connect” button becomes enabled, there’s a short delay. I thought it might be useful to provide some loading feedback so users understand that the field is being validated. > > > > > > That's not what i am fixing here. What this pr does is to make it so that users don't have to close little error box that pops up at the bottom there. <img alt="image" width="452" height="140" src="https://private-user-images.githubusercontent.com/76224658/531236504-44c576c4-3b37-4594-af0e-9fb4343230f2.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjcxOTEyNTMsIm5iZiI6MTc2NzE5MDk1MywicGF0aCI6Ii83NjIyNDY1OC81MzEyMzY1MDQtNDRjNTc2YzQtM2IzNy00NTk0LWFmMGUtOWZiNDM0MzIzMGYyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEyMzElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMjMxVDE0MjIzM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE3ZTU5ZGI5OWY1NGY1MDJiYjNmNTJkZGE0ZDIyOTU0ZTdmMDExNDBkMDNiOWMzYjZjNTkxOGFjZmZjYjA1ZjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.NiakxKaktj5XtkUWwswwXJB3zjMfvSBHNE6-i1GcKYA";> > > Ok, then we can add it in a separate PR This is addressed in #36880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://private-user-images.githubusercontent.com/76224658/531236504-44c576c4-3b37-4594-af0e-9fb4343230f2.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjcxOTEyNTMsIm5iZiI6MTc2NzE5MDk1MywicGF0aCI6Ii83NjIyNDY1OC81MzEyMzY1MDQtNDRjNTc2YzQtM2IzNy00NTk0LWFmMGUtOWZiNDM0MzIzMGYyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEyMzElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMjMxVDE0MjIzM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE3ZTU5ZGI5OWY1NGY1MDJiYjNmNTJkZGE0ZDIyOTU0ZTdmMDExNDBkMDNiOWMzYjZjNTkxOGFjZmZjYjA1ZjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.NiakxKaktj5XtkUWwswwXJB3zjMfvSBHNE6-i1GcKYA"](https://private-user-images.githubusercontent.com/76224658/531236504-44c576c4-3b37-4594-af0e-9fb4343230f2.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjcxOTEyNTMsIm5iZiI6MTc2NzE5MDk1MywicGF0aCI6Ii83NjIyNDY1OC81MzEyMzY1MDQtNDRjNTc2YzQtM2IzNy00NTk0LWFmMGUtOWZiNDM0MzIzMGYyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEyMzElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMjMxVDE0MjIzM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE3ZTU5ZGI5OWY1NGY1MDJiYjNmNTJkZGE0ZDIyOTU0ZTdmMDExNDBkMDNiOWMzYjZjNTkxOGFjZmZjYjA1ZjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.NiakxKaktj5XtkUWwswwXJB3zjMfvSBHNE6-i1GcKYA"){kind=link}