ypandey-fluidata opened a new issue, #36979:
URL: https://github.com/apache/superset/issues/36979

   ### Bug description
   
   #Change in superset_config.py
   
   Change 1:
   
   APP_NAME = "OGOS"
   APP_ICON = "/static/assets/images/superset-logo-horiz.png"
   FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
   loading_icon = "/static/assets/images/loading.gif"
   LOGO_TARGET_PATH = "/"
   
   Change 2:
   
     superset_test:
       build:
         context: .
         dockerfile: Dockerfile
       image: apache/ogos:test 
       container_name: superset_app_test
       user: root
       depends_on:
         - db_test
         - redis_test
       environment:
         SUPERSET_SECRET_KEY: "change_this_to_a_secure_key_test" # this is the 
key, do not change it.
         SUPERSET_SQLALCHEMY_DATABASE_URI: 
postgresql+psycopg2://superset_test:superset_test_pwd@db_test:5432/superset_test
         SUPERSET_ENV: production
       ports:
         - "8091:8088"
       volumes:
         - superset_test_home:/app/superset_home
         - ./superset_config_test.py:/app/pythonpath/superset_config.py
       command: >
         /bin/bash -c "
           pip install --no-cache-dir psycopg2-binary &&
           superset db upgrade &&
           superset init &&
           /usr/bin/run-server.sh
         "
       restart: unless-stopped
        
   #Change in Dockerfile
   
   #stage1
   FROM node:20-bookworm AS frontend-builder
   
   RUN apt-get update && apt-get install -y \
       git \
       libzstd-dev \
       zstd \
       python3 \
       make \
       g++ \
       && rm -rf /var/lib/apt/lists/*
   
   WORKDIR /superset
   
   RUN git clone --branch 6.0.0 https://github.com/apache/superset.git .
   
   WORKDIR /superset/superset-frontend
   
   RUN mkdir -p src/assets/images/brand
   
   COPY fdos_loader.gif src/assets/images/brand/ogos_loader.gif
   COPY fdos_logo_trans.png src/assets/images/brand/ogos_logo_trans.png
   COPY fdos_favicon.png src/assets/images/brand/ogos_favicon.png
   
   RUN cp src/assets/images/brand/ogos_loader.gif src/assets/images/loading.gif
   RUN cp src/assets/images/brand/ogos_logo_trans.png 
src/assets/images/superset-logo-horiz.png
   RUN cp src/assets/images/brand/ogos_favicon.png src/assets/images/favicon.png
   
   RUN npm ci
   RUN npm run build
   
   #stage2
   FROM apache/superset:6.0.0
   
   USER root
   
   RUN pip install --no-cache-dir psycopg2-binary
   
   COPY --from=frontend-builder \
     /superset/superset/static/assets \
     /app/superset/static/assets
   
   USER superset
   
   ----
   I am trying to build a custom superset image with my logo, favicon, loading. 
i have put the files in root folder and used this Dockerfile and 
docker-compose.yml it works fine. My logo works perfectly fine, Now the issue 
comes here is when i checked the dev tools still the pre built loading.gif and 
favicon.png are still not replace. 
   
   ### Screenshots/recordings
   
   _No response_
   
   ### Superset version
   
   master / latest-dev
   
   ### Python version
   
   3.9
   
   ### Node version
   
   16
   
   ### Browser
   
   Chrome
   
   ### Additional context
   
   _No response_
   
   ### Checklist
   
   - [ ] I have searched Superset docs and Slack and didn't find a solution to 
my problem.
   - [ ] I have searched the GitHub issue tracker and didn't find a similar bug 
report.
   - [ ] I have checked Superset's logs for errors and if I found a relevant 
Python stacktrace, I included it here as text in the "additional context" 
section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to