dosubot[bot] commented on issue #36979: URL: https://github.com/apache/superset/issues/36979#issuecomment-3723598668
<!-- Answer --> Superset 6.0.0/master recently changed how the loading spinner works: it now uses an animated SVG by default and lets you set a custom image via the theme token `brandSpinnerUrl`—replacing `loading.gif` directly may no longer have any effect. To use your own loading image, set `brandSpinnerUrl` in your theme config to the path of your custom GIF or PNG (for example, `/static/assets/images/ogos_loader.gif`). See [the merged PR for details](https://github.com/apache/superset/pull/34764). For the favicon, Superset still uses the `FAVICONS` config in `superset_config.py`, which is rendered in the HTML head. Make sure your custom favicon is present in the built static assets and referenced correctly in the config. If you still see the old favicon or spinner, clear your browser cache and localStorage—browsers cache these assets aggressively. Also, Superset 6.0.0+ requires Node 20.x for frontend builds; using Node 16 can cause missing assets or build failures. Double-check your Dockerfile and build steps to ensure your custom images are copied before running the frontend build, and that the build completes successfully. If you follow these steps, your custom branding should appear as expected. References: - [Custom loading spinner via theme token](https://github.com/apache/superset/pull/34764) - [How favicon config works](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/templates/superset/base.html#L24-L32) <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/9ec600f6-0b3e-45d6-9ff2-70decf19e293?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/9ec600f6-0b3e-45d6-9ff2-70decf19e293?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/9ec600f6-0b3e-45d6-9ff2-70decf19e293?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/9ec600f6-0b3e-45d6-9ff2-70decf19e293?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/9ec600f6-0b3e-45d6-9ff2-70decf19e293?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/9ec600f6-0b3e-45d6-9ff2-70decf19e293?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/9ec600f6-0b3e-45d6-9ff2-70decf19e293?feedback_type=other)</sup> [](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=github) [](https://cursor.com/link/prompt?text=Superset%206.0.0/master%20recently%20changed%20how%20the%20loading%20spinner%20works%3A%20it%20now%20uses%20an%20animated%20SVG%20by%20default%20and%20lets%20you%20set%20a%20custom%20image%20via%20the%20theme%20token%20%60brandSpinnerUrl%60%E2%80%94replacing%20%60loading.gif%60%20directly%20may%20no%20longer%20have%20any%20effect.%20To%20use%20your%20own%20loading%20image%2C%20set%20%60brandSpinnerUrl%60%20in%20your%20theme%20config%20to%20the%20path%20of%20your%20custom%20GIF%20or%20PNG%20%28for%20example%2C%20%60/static/assets/images/ogos_loader.gif%60%29.%20See%20%5Bthe%20merged%20PR%20for%20details%5D%28https%3A//github.com/apache/superset/pull/34764%29.%0A%0AFor%20the%20favicon%2C%20Superset%20still%20uses%20the%20%60FAVICONS%60%20config%20in% 20%60superset_config.py%60%2C%20which%20is%20rendered%20in%20the%20HTML%20head.%20Make%20sure%20your%20custom%20favicon%20is%20present%20in%20the%20built%20static%20assets%20and%20referenced%20correctly%20in%20the%20config.%20If%20you%20still%20see%20the%20old%20favicon%20or%20spinner%2C%20clear%20your%20browser%20cache%20and%20localStorage%E2%80%94browsers%20cache%20these%20assets%20aggressively.%0A%0AAlso%2C%20Superset%206.0.0%2B%20requires%20Node%2020.x%20for%20frontend%20builds%3B%20using%20Node%2016%20can%20cause%20missing%20assets%20or%20build%20failures.%20Double-check%20your%20Dockerfile%20and%20build%20steps%20to%20ensure%20your%20custom%20images%20are%20copied%20before%20running%20the%20frontend%20build%2C%20and%20that%20the%20build%20completes%20successfully.%20If%20you%20follow%20these%20steps%2C%20your%20custom%20branding%20should%20appear%20as%20expected.%20%0A%0AReferences%3A%20%20%0A-%20%5BCustom%20loading%20spinner%20via%20theme%20token%5D%28https%3A//github.com/apa che/superset/pull/34764%29%20%20%0A-%20%5BHow%20favicon%20config%20works%5D%28https%3A//github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/templates/superset/base.html%23L24-L32%29) [](https://go.dosu.dev/discord-bot) [](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/36979) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
