dosubot[bot] commented on issue #36979:
URL: https://github.com/apache/superset/issues/36979#issuecomment-3723674191

   <!-- Answer -->
   A few things to check:
   
   1. Superset only loads the theme config from THEME, not THEME_DEFAULT. Make 
sure you assign your theme dictionary to THEME in superset_config.py, like:
      ```python
      THEME = {
          "algorithm": "default",
          "token": {
              # ... your tokens ...
              "brandSpinnerUrl": "/static/assets/images/loading.gif",
          }
      }
      ```
      Otherwise, your custom spinner and logo won't be picked up by the 
frontend. 
[Reference](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/views/base.py#L209-L378)
   
   2. If you've ever used the theme editor or loaded Superset before, your 
browser's localStorage may have a saved theme that overrides the config. Clear 
localStorage (look for the key `superset-theme`) and refresh the page. 
[Reference](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/theme/ThemeController.tsx#L43-L246)
   
   3. For the favicon, make sure your FAVICONS config in superset_config.py 
points to the correct path and that the file exists in the built static assets. 
The favicon is rendered from this config in the HTML head. 
[Reference](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/templates/superset/base.html#L24-L31)
   
   4. Superset 6.0.0+ requires Node 20.x for frontend builds. Using Node 16 can 
cause missing or outdated assets. 
[Reference](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/Dockerfile#L32-L200)
   
   5. After rebuilding, clear your browser cache to ensure you aren't seeing 
cached assets.
   
   If you follow these steps and still don't see your custom spinner or 
favicon, use your browser's dev tools (Network tab) to check which asset paths 
are being loaded and verify that your custom files are present in the container 
at /app/superset/static/assets/images/.
   
   
   <!-- Dosu Comment Footer -->
   *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).*
   
   ---
   <sup>How did I do? 
[Good](https://app.dosu.dev/response-feedback/6aab220f-30d3-4876-80b1-1308c82d9abb?feedback_type=great_response)
 | 
[Irrelevant](https://app.dosu.dev/response-feedback/6aab220f-30d3-4876-80b1-1308c82d9abb?feedback_type=irrelevant_answer)
 | 
[Incorrect](https://app.dosu.dev/response-feedback/6aab220f-30d3-4876-80b1-1308c82d9abb?feedback_type=incorrect_sources)
 | 
[Verbose](https://app.dosu.dev/response-feedback/6aab220f-30d3-4876-80b1-1308c82d9abb?feedback_type=too_verbose)
 | 
[Hallucination](https://app.dosu.dev/response-feedback/6aab220f-30d3-4876-80b1-1308c82d9abb?feedback_type=hallucination)
 | [Report 
🐛](https://app.dosu.dev/response-feedback/6aab220f-30d3-4876-80b1-1308c82d9abb?feedback_type=bug_report)
 | 
[Other](https://app.dosu.dev/response-feedback/6aab220f-30d3-4876-80b1-1308c82d9abb?feedback_type=other)</sup>
   
   [![Chat with 
Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=github)&nbsp;[![Open
 in 
Cursor](https://dosu.dev/dosu-in-cursor.svg)](https://cursor.com/link/prompt?text=A%20few%20things%20to%20check%3A%0A%0A1.%20Superset%20only%20loads%20the%20theme%20config%20from%20THEME%2C%20not%20THEME_DEFAULT.%20Make%20sure%20you%20assign%20your%20theme%20dictionary%20to%20THEME%20in%20superset_config.py%2C%20like%3A%0A%20%20%20%60%60%60python%0A%20%20%20THEME%20%3D%20%7B%0A%20%20%20%20%20%20%20%22algorithm%22%3A%20%22default%22%2C%0A%20%20%20%20%20%20%20%22token%22%3A%20%7B%0A%20%20%20%20%20%20%20%20%20%20%20%23%20...%20your%20tokens%20...%0A%20%20%20%20%20%20%20%20%20%20%20%22brandSpinnerUrl%22%3A%20%22/static/assets/images/loading.gif%22%2C%0A%20%20%20%20%20%20%20%7D%0A%20%20%20%7D%0A%20%20%20%60%60%60%0A%20%20%20Otherwise%2C%20your%20custom%20spinner%20and%20logo%20won%27t%20be%20picked%20up%20by%20the%20frontend.%20%5BRe
 
ference%5D%28https%3A//github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/views/base.py%23L209-L378%29%0A%0A2.%20If%20you%27ve%20ever%20used%20the%20theme%20editor%20or%20loaded%20Superset%20before%2C%20your%20browser%27s%20localStorage%20may%20have%20a%20saved%20theme%20that%20overrides%20the%20config.%20Clear%20localStorage%20%28look%20for%20the%20key%20%60superset-theme%60%29%20and%20refresh%20the%20page.%20%5BReference%5D%28https%3A//github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/theme/ThemeController.tsx%23L43-L246%29%0A%0A3.%20For%20the%20favicon%2C%20make%20sure%20your%20FAVICONS%20config%20in%20superset_config.py%20points%20to%20the%20correct%20path%20and%20that%20the%20file%20exists%20in%20the%20built%20static%20assets.%20The%20favicon%20is%20rendered%20from%20this%20config%20in%20the%20HTML%20head.%20%5BReference%5D%28https%3A//github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377
 
799c/superset/templates/superset/base.html%23L24-L31%29%0A%0A4.%20Superset%206.0.0%2B%20requires%20Node%2020.x%20for%20frontend%20builds.%20Using%20Node%2016%20can%20cause%20missing%20or%20outdated%20assets.%20%5BReference%5D%28https%3A//github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/Dockerfile%23L32-L200%29%0A%0A5.%20After%20rebuilding%2C%20clear%20your%20browser%20cache%20to%20ensure%20you%20aren%27t%20seeing%20cached%20assets.%0A%0AIf%20you%20follow%20these%20steps%20and%20still%20don%27t%20see%20your%20custom%20spinner%20or%20favicon%2C%20use%20your%20browser%27s%20dev%20tools%20%28Network%20tab%29%20to%20check%20which%20asset%20paths%20are%20being%20loaded%20and%20verify%20that%20your%20custom%20files%20are%20present%20in%20the%20container%20at%20/app/superset/static/assets/images/.)&nbsp;[![Join
 
Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share
 on X](https://img.shiel
 
ds.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/36979)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to