bito-code-review[bot] commented on code in PR #38402:
URL: https://github.com/apache/superset/pull/38402#discussion_r2911203159
##########
superset/mcp_service/chart/chart_utils.py:
##########
@@ -952,6 +1006,9 @@ def generate_chart_name(
elif isinstance(config, MixedTimeseriesChartConfig):
what = _mixed_timeseries_what(config)
context = _summarize_filters(config.filters)
+ elif isinstance(config, HandlebarsChartConfig):
+ what = _handlebars_chart_what(config)
+ context = _summarize_filters(getattr(config, "filters", None))
else:
return "Chart"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Runtime Error: Removing Used Function</b></div>
<div id="fix">
Removing _resolve_viz_type will cause NameError at runtime when
analyze_chart_capabilities or analyze_chart_semantics is called with
chart=None, as they rely on this function to determine viz_type from config.
The function is also imported and tested in test_handlebars_chart.py.
</div>
</div>
<small><i>Code Review Run #ebc624</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
