bito-code-review[bot] commented on code in PR #38402:
URL: https://github.com/apache/superset/pull/38402#discussion_r2911819873
##########
superset/mcp_service/chart/chart_utils.py:
##########
@@ -952,6 +1006,9 @@ def generate_chart_name(
elif isinstance(config, MixedTimeseriesChartConfig):
what = _mixed_timeseries_what(config)
context = _summarize_filters(config.filters)
+ elif isinstance(config, HandlebarsChartConfig):
+ what = _handlebars_chart_what(config)
+ context = _summarize_filters(getattr(config, "filters", None))
else:
return "Chart"
Review Comment:
<!-- Bito Reply -->
You're correct—the PR diff doesn't show `_resolve_viz_type` being removed
from `chart_utils.py`. It's still defined and called as you noted, so the
runtime error concern from the suggestion doesn't apply here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
