fitzee commented on PR #39885: URL: https://github.com/apache/superset/pull/39885#issuecomment-4383762776
Thanks for the review (and please pass thanks to the bot wrangler). Both points addressed in 8eab7e9ca4: **1. Comparator preserving default semantics** — Replaced `localeCompare()` with codepoint comparison (`<` / `>`), matching AG Grid's `defaultComparator` behavior. Plain (non-HTML) string columns now sort identically to before this PR — e.g. `'Z'` still sorts before `'a'`. Added `htmlTextComparator preserves default codepoint ordering for plain strings` to the test file to lock that in. **2. Server-pagination scope** — Agreed: server-paginated tables delegate sort to the backend (via the existing `comparator: () => 0` override), and the database has no way to extract visible text from an HTML column. Rather than expand scope into server-side handling, I've documented the limitation with a comment in `useColDefs.ts` next to the new branch and made the client-side scope explicit in the PR description. Server-side normalization for HTML columns would be a separate, larger change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
