fitzee commented on PR #39885: URL: https://github.com/apache/superset/pull/39885#issuecomment-4384319002
Thanks for the bot review (and human reviewers — your patience). Both points addressed in the latest push (`d395ea6109` → rebased to `ec56d0038b`): **1. Performance — `htmlTextFilterValueGetter.ts`** — Memoized `stripHtmlToText` with a module-level `Map<string, string>` cache. Sort comparators run O(n log n) times against the same set of cell values, so reparsing on every call was a measurable cost on large tables. Cache is bounded by the number of unique HTML strings in the dataset. **2. Server-pagination consistency — `useColDefs.ts`** — Gated the string-column branch on `!serverPagination`. In server-pagination mode AG Grid converts the typed filter value into a backend query that operates on the raw HTML stored in the database; stripping HTML client-side via `filterValueGetter` was creating exactly the inconsistency you flagged (typed text searched against visible labels client-side but raw HTML server-side). With the gate, server-paginated tables now behave as they did pre-PR — raw HTML semantics, consistent between client and server. Server-side HTML normalization for paginated tables would be a separate, larger change. The existing tests still pass; the change is a strict-superset of the previous behavior in client-side mode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
