bito-code-review[bot] commented on PR #39885:
URL: https://github.com/apache/superset/pull/39885#issuecomment-4384273358
<!-- Bito Reply -->
The flagged issue is correct: when serverPagination is enabled, client-side
filtering uses htmlTextFilterValueGetter to strip HTML for visible text, but
server-side filtering operates on raw HTML, causing inconsistent results. To
resolve, gate the htmlTextFilterValueGetter and htmlTextComparator behind
client-side mode by adding !serverPagination to the condition.
**superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/useColDefs.ts**
```
...(dataType === GenericDataType.String && !serverPagination && {
// HTML cells (e.g. anchor markup) are rendered by TextCellRenderer
// via dangerouslySetInnerHTML; without these the filter and sort
// operate on raw HTML so the URL inside the markup dictates order
// and the "Contains" filter matches against the raw HTML string.
//
// Scope: client-side only. When `serverPagination` is enabled,
// filtering and sorting are delegated to the server; the database
// does not know to extract visible text from HTML, so this is
gated
// to avoid inconsistency between client and server evaluation.
filterValueGetter: htmlTextFilterValueGetter,
comparator: htmlTextComparator,
}),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
