aminghadersohi commented on PR #40124: URL: https://github.com/apache/superset/pull/40124#issuecomment-4552638974
@fitzee @richardfogaca — all feedback from both reviews is addressed. Summary of commits pushed after @fitzee's approval on `d6db27c`: - `790e56215a` — **fitzee nit 1**: `min_length=1` on `target_tab` rejects empty strings at the schema layer instead of producing a confusing "Tab '' not found" error - `790e56215a` — **fitzee nit 2**: `assert` → `raise RuntimeError(...)` so the invariant holds under `python -O` - `5b486ba217` — schema-level test for the empty `target_tab` rejection - `cf53282af1` — **richardfogaca note 2**: `_collect_available_tab_names` now returns `Label (TAB-abc123)` entries so callers can always retry with the component ID even with duplicate names or blank labels - `ba7969c25a` — **richardfogaca note 1**: `AddChartToDashboardResponse.error` now has a `@field_validator` wrapping with `sanitize_for_llm_context`, consistent with `DashboardError.error` All CI checks green, branch current with `master`. Would appreciate a re-review when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
