aminghadersohi commented on PR #40124:
URL: https://github.com/apache/superset/pull/40124#issuecomment-4513808457
@fitzee — thanks for the LGTM! Both nits were already addressed in a prior
commit before your review:
1. **min_length=1 on target_tab** — added in 847b841056 ("fix(mcp): address
fitzee review nits"). Empty-string `target_tab` is now rejected at the schema
layer.
2. **assert → RuntimeError** — also in 847b841056. The `assert parent_id is
not None` was replaced with `raise RuntimeError("unreachable: tab_error is None
implies parent_id is str")`.
HEAD is 4044541f60. No new changes needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
