aminghadersohi commented on code in PR #40124:
URL: https://github.com/apache/superset/pull/40124#discussion_r3277191098
##########
superset/mcp_service/dashboard/schemas.py:
##########
@@ -467,7 +467,15 @@ class AddChartToDashboardRequest(BaseModel):
)
chart_id: int = Field(..., description="ID of the chart to add to the
dashboard")
target_tab: str | None = Field(
- None, description="Target tab name (if dashboard has tabs)"
+ None,
+ description=(
+ "Tab to place the chart in. Accepts a tab display name "
+ "(e.g. 'Sales') or a tab component ID (e.g. 'TAB-abc123'). "
+ "Matching is case-insensitive and ignores leading/trailing emoji. "
Review Comment:
Fixed in commit `debe59f16c`. The description was updated from "ignores
leading/trailing emoji" to "strips all emoji" (and explicitly distinguishes
display-name matching from component ID matching). The current wording in
`schemas.py` now accurately reflects what `_normalize_tab_text()` does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
