rusackas commented on code in PR #41132:
URL: https://github.com/apache/superset/pull/41132#discussion_r3488544460
##########
superset-frontend/src/dashboard/components/SaveModal.tsx:
##########
@@ -65,18 +65,18 @@ type SaveModalProps = {
function SaveModal({
saveType: initialSaveType = SAVE_TYPE_OVERWRITE,
- colorNamespace,
- colorScheme,
+ colorNamespace: _colorNamespace,
Review Comment:
Same story as the BigNumber and Dashboard ones...
`expandedSlices`/`colorNamespace`/`colorScheme` drill up through
`useHeaderActionsMenu` into Header's `mapStateToProps`, so fully trimming them
means unwinding that chain too. I'm inclined to fold all three of these into
one focused follow-up rather than smuggle it into the lint flip. Work for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
