rusackas commented on code in PR #41132:
URL: https://github.com/apache/superset/pull/41132#discussion_r3488876115


##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx:
##########
@@ -141,8 +141,6 @@ const VerticalFilterBar: FC<VerticalBarProps> = ({
   onPendingCustomizationDataMaskChange,
   toggleFiltersBar,
   width,
-  clearAllTriggers,
-  onClearAllComplete,
 }) => {
   const theme = useTheme();

Review Comment:
   Both `clearAllTriggers` and `onClearAllComplete` were unused in the body, so 
these are dead destructures the rule flagged. The parent still passing them is 
harmless and predates this PR; trimming that surface is its own change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to