rusackas commented on code in PR #41132:
URL: https://github.com/apache/superset/pull/41132#discussion_r3488875699
##########
superset-frontend/src/features/allEntities/AllEntitiesTable.tsx:
##########
@@ -59,7 +59,7 @@ interface AllEntitiesTableProps {
}
export default function AllEntitiesTable({
- search = '',
+ search: _search = '',
Review Comment:
`search` was already destructured-but-unused on `master`, so the `_` rename
is just the lint fix, not new dead code. Pulling it out of the interface and
caller is a behavior-adjacent trim I would keep out of this rule flip.
##########
superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridRenderer.tsx:
##########
@@ -118,7 +118,6 @@ interface MatrixifyGridRendererProps {
function MatrixifyGridRenderer({
formData,
datasource,
- width,
height,
hooks,
}: MatrixifyGridRendererProps) {
Review Comment:
`width` was unused in the body, so dropping it from the destructure is the
fix. `SuperChart` still passing it is harmless and predates this PR; trimming
the interface is its own cleanup, not this lint flip.
##########
superset-frontend/src/explore/components/DataTablesPane/components/SamplesPane.tsx:
##########
@@ -60,7 +60,6 @@ export const SamplesPane = ({
queryFormData,
queryForce,
setForceQuery,
- isVisible,
canDownload,
Review Comment:
`isVisible` was unused in the component, so removing the destructure is the
fix here. The caller still passing it compiles fine and predates this PR;
trimming it from the type and callers is a separate cleanup.
##########
superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.tsx:
##########
@@ -170,7 +169,6 @@ const TabsRenderer = memo<TabsRendererProps>(
tabBarPaddingLeft = 0,
onTabsReorder,
isEditingTabTitle = false,
- onTabTitleEditingChange,
}) => {
const [activeId, setActiveId] = useState<string | null>(null);
Review Comment:
This was already destructured-but-unused on `master`, the callback was never
invoked, so there is no regression here, just the dead destructure removed.
Actually wiring `onTabTitleEditingChange` would be a feature, not this lint
flip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
