rusackas commented on code in PR #41492:
URL: https://github.com/apache/superset/pull/41492#discussion_r3625178486
##########
tests/unit_tests/db_engine_specs/test_base.py:
##########
@@ -1383,3 +1383,11 @@ def
test_base_spec_public_information_includes_supports_offset() -> None:
assert "supports_offset" in info
assert info["supports_offset"] is True
+
+
+def test_get_public_information_exposes_ansi_identifier_quote() -> None:
+ """The base spec advertises ANSI double quotes for identifier quoting."""
+ assert BaseEngineSpec.get_public_information()["identifier_quote"] == {
+ "start": '"',
+ "end": '"',
+ }
Review Comment:
Not a bug — `BaseEngineSpec` is imported at module level in this file (line
36: `from superset.db_engine_specs.base import BaseEngineSpec,
convert_inspector_columns`), so it's already in scope for this test. The
neighboring tests' local imports are just redundant, not required. No change
needed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
