rusackas commented on PR #41492: URL: https://github.com/apache/superset/pull/41492#issuecomment-5098997901
Good catch, fixed in 7138c93. `insertMatch` still hardcoded an ANSI double quote when the caption had a space instead of reusing `quoteIdentifier` with the engine's quote chars like `value` already does. Added a test asserting the inserted text matches the dialect's quote chars. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
