rusackas commented on code in PR #41492:
URL: https://github.com/apache/superset/pull/41492#discussion_r3664772634
##########
superset/db_engine_specs/mssql.py:
##########
@@ -53,6 +53,11 @@ class MssqlEngineSpec(BaseEngineSpec):
engine = "mssql"
engine_name = "Microsoft SQL Server"
+ # SQL Server quotes identifiers with square brackets; only the closing
bracket
+ # needs escaping (by doubling).
+ identifier_quote_start: str = "["
+ identifier_quote_end: str = "]"
Review Comment:
Good catch, fixed! SAP ASE/SQL Anywhere quote with double quotes, not
brackets, so `SybaseEngineSpec` now overrides `identifier_quote_start`/`end`
instead of inheriting MSSQL's.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
