bito-code-review[bot] commented on code in PR #42296: URL: https://github.com/apache/superset/pull/42296#discussion_r3626624894
########## superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.tsx: ########## @@ -155,17 +156,29 @@ const ChartContextMenu = ( const [drillModalIsOpen, setDrillModalIsOpen] = useState(false); const [drillByColumn, setDrillByColumn] = useState<Column>(); + // Drill by config as selected in the submenu (e.g. with the chosen + // x-axis/series filter scope applied), used over the raw context filters + const [selectedDrillByConfig, setSelectedDrillByConfig] = + useState<ContextMenuFilters['drillBy']>(); Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing test coverage for new state</b></div> <div id="fix"> The new `selectedDrillByConfig` state and the derived `drillByModalConfig` at line 191 lack test coverage. According to adaptive rule [6262], tests should verify actual business logic behavior rather than just component rendering. Add tests that assert the submenu-selected config takes precedence over the raw context filters when opening the DrillByModal. </div> </div> <small><i>Code Review Run #78db08</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
