bito-code-review[bot] commented on code in PR #42296: URL: https://github.com/apache/superset/pull/42296#discussion_r3627527552
########## superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.tsx: ########## @@ -155,17 +156,29 @@ const ChartContextMenu = ( const [drillModalIsOpen, setDrillModalIsOpen] = useState(false); const [drillByColumn, setDrillByColumn] = useState<Column>(); + // Drill by config as selected in the submenu (e.g. with the chosen + // x-axis/series filter scope applied), used over the raw context filters + const [selectedDrillByConfig, setSelectedDrillByConfig] = + useState<ContextMenuFilters['drillBy']>(); Review Comment: <!-- Bito Reply --> The existing test coverage for the scope selector in the drill-by configuration is sufficient for the current implementation. Since the new state is a direct mapping of the existing configuration logic, adding a separate test for this trivial glue code is not necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
