bito-code-review[bot] commented on code in PR #42296: URL: https://github.com/apache/superset/pull/42296#discussion_r3627614096
########## superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.tsx: ########## @@ -155,17 +156,29 @@ const ChartContextMenu = ( const [drillModalIsOpen, setDrillModalIsOpen] = useState(false); const [drillByColumn, setDrillByColumn] = useState<Column>(); + // Drill by config as selected in the submenu (e.g. with the chosen + // x-axis/series filter scope applied), used over the raw context filters + const [selectedDrillByConfig, setSelectedDrillByConfig] = + useState<ContextMenuFilters['drillBy']>(); Review Comment: <!-- Bito Reply --> The user has addressed the reviewer's concern regarding missing test coverage for the new `selectedDrillByConfig` state. The user noted that the path is already covered in `DrillBySubmenu.test.tsx` and that the current implementation is trivial glue, making a separate test unnecessary. The reviewer agreed with this assessment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
