bito-code-review[bot] commented on code in PR #36350:
URL: https://github.com/apache/superset/pull/36350#discussion_r3661743268
##########
superset-frontend/src/explore/exploreUtils/index.ts:
##########
@@ -315,10 +316,14 @@ export const buildV1ChartDataPayload = async ({
resultType,
setDataMask,
ownState,
+ clientId,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing test for clientId</b></div>
<div id="fix">
The `clientId` parameter (line 319) is added to `buildV1ChartDataPayload`
but no test verifies the returned payload contains `client_id`. BITO.md
adaptive rule [6262] requires tests to verify actual business logic behavior,
not just absence of errors.
</div>
</div>
<small><i>Code Review Run #d618e4</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
