Re: [PR] fix(explore): stop button cancels running chart queries in the backend [superset]

[via GitHub]

bito-code-review[bot] commented on code in PR #36350:
URL: https://github.com/apache/superset/pull/36350#discussion_r3661880895


##########
superset-frontend/playwright/generators/docs/screenshot-manifest.yaml:
##########
@@ -31,1363 +31,1363 @@
 images:
   # --- tutorial (37) ---
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard";
-    image_url: 
"https://superset.apache.org/img/tutorial/tutorial_01_add_database_connection.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard'
+    image_url: 
'https://superset.apache.org/img/tutorial/tutorial_01_add_database_connection.png'
     output_path: 
docs/static/img/tutorial/tutorial_01_add_database_connection.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/creating-your-first-dashboard.mdx
     app_path: null
     selector: null
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard";
-    image_url: 
"https://superset.apache.org/img/tutorial/tutorial_02_select_database.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard'
+    image_url: 
'https://superset.apache.org/img/tutorial/tutorial_02_select_database.png'
     output_path: docs/static/img/tutorial/tutorial_02_select_database.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/creating-your-first-dashboard.mdx
     app_path: null
     selector: .ant-modal-container
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard";
-    image_url: 
"https://superset.apache.org/img/tutorial/tutorial_03a_database_connection_string_link.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard'
+    image_url: 
'https://superset.apache.org/img/tutorial/tutorial_03a_database_connection_string_link.png'
     output_path: 
docs/static/img/tutorial/tutorial_03a_database_connection_string_link.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/creating-your-first-dashboard.mdx
     app_path: null
     selector: .ant-modal-container
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard";
-    image_url: 
"https://superset.apache.org/img/tutorial/tutorial_03b_connection_string_details.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard'
+    image_url: 
'https://superset.apache.org/img/tutorial/tutorial_03b_connection_string_details.png'
     output_path: 
docs/static/img/tutorial/tutorial_03b_connection_string_details.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/creating-your-first-dashboard.mdx
     app_path: null
     selector: .ant-modal-container
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard";
-    image_url: 
"https://superset.apache.org/img/tutorial/tutorial_09_add_new_table.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard'
+    image_url: 
'https://superset.apache.org/img/tutorial/tutorial_09_add_new_table.png'
     output_path: docs/static/img/tutorial/tutorial_09_add_new_table.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/creating-your-first-dashboard.mdx
     app_path: null
     selector: .ant-modal-container
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard";
-    image_url: 
"https://superset.apache.org/img/tutorial/tutorial_calculated_column.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard'
+    image_url: 
'https://superset.apache.org/img/tutorial/tutorial_calculated_column.png'
     output_path: docs/static/img/tutorial/tutorial_calculated_column.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/creating-your-first-dashboard.mdx
     app_path: null
     selector: null
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard";
-    image_url: 
"https://superset.apache.org/img/tutorial/tutorial_column_properties.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard'
+    image_url: 
'https://superset.apache.org/img/tutorial/tutorial_column_properties.png'
     output_path: docs/static/img/tutorial/tutorial_column_properties.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/creating-your-first-dashboard.mdx
     app_path: null
     selector: null
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard";
-    image_url: 
"https://superset.apache.org/img/tutorial/tutorial_dashboard_access.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard'
+    image_url: 
'https://superset.apache.org/img/tutorial/tutorial_dashboard_access.png'
     output_path: docs/static/img/tutorial/tutorial_dashboard_access.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/creating-your-first-dashboard.mdx
     app_path: null
     selector: .ant-modal-container
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard";
-    image_url: 
"https://superset.apache.org/img/tutorial/tutorial_explore_run.jpg";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard'
+    image_url: 
'https://superset.apache.org/img/tutorial/tutorial_explore_run.jpg'
     output_path: docs/static/img/tutorial/tutorial_explore_run.jpg
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/creating-your-first-dashboard.mdx
     app_path: null
     selector: null
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard";
-    image_url: 
"https://superset.apache.org/img/tutorial/tutorial_explore_settings.jpg";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard'
+    image_url: 
'https://superset.apache.org/img/tutorial/tutorial_explore_settings.jpg'
     output_path: docs/static/img/tutorial/tutorial_explore_settings.jpg
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/creating-your-first-dashboard.mdx
     app_path: null
     selector: null
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard";
-    image_url: 
"https://superset.apache.org/img/tutorial/tutorial_launch_explore.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard'
+    image_url: 
'https://superset.apache.org/img/tutorial/tutorial_launch_explore.png'
     output_path: docs/static/img/tutorial/tutorial_launch_explore.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/creating-your-first-dashboard.mdx
     app_path: null
     selector: null
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard";
-    image_url: 
"https://superset.apache.org/img/tutorial/tutorial_sql_metric.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/creating-your-first-dashboard'
+    image_url: 
'https://superset.apache.org/img/tutorial/tutorial_sql_metric.png'
     output_path: docs/static/img/tutorial/tutorial_sql_metric.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/creating-your-first-dashboard.mdx
     app_path: null
     selector: null
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/exploring-data";
-    image_url: 
"https://superset.apache.org/img/tutorial/advanced_analytics_base.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/exploring-data'
+    image_url: 
'https://superset.apache.org/img/tutorial/advanced_analytics_base.png'
     output_path: docs/static/img/tutorial/advanced_analytics_base.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/exploring-data.mdx
     app_path: null
-    selector: "[data-test=\"slice-container\"]"
+    selector: '[data-test="slice-container"]'
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/exploring-data";
-    image_url: 
"https://superset.apache.org/img/tutorial/allow-file-uploads.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/exploring-data'
+    image_url: 
'https://superset.apache.org/img/tutorial/allow-file-uploads.png'
     output_path: docs/static/img/tutorial/allow-file-uploads.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/exploring-data.mdx
     app_path: null
     selector: .ant-modal-container
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/exploring-data";
-    image_url: "https://superset.apache.org/img/tutorial/annotation.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/exploring-data'
+    image_url: 'https://superset.apache.org/img/tutorial/annotation.png'
     output_path: docs/static/img/tutorial/annotation.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/exploring-data.mdx
     app_path: null
-    selector: "[data-test=\"slice-container\"]"
+    selector: '[data-test="slice-container"]'
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/exploring-data";
-    image_url: 
"https://superset.apache.org/img/tutorial/annotation_settings.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/exploring-data'
+    image_url: 
'https://superset.apache.org/img/tutorial/annotation_settings.png'
     output_path: docs/static/img/tutorial/annotation_settings.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/exploring-data.mdx
     app_path: null
     selector: null
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/exploring-data";
-    image_url: 
"https://superset.apache.org/img/tutorial/average_aggregate_for_cost.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/exploring-data'
+    image_url: 
'https://superset.apache.org/img/tutorial/average_aggregate_for_cost.png'
     output_path: docs/static/img/tutorial/average_aggregate_for_cost.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/exploring-data.mdx
     app_path: null
-    selector: "[data-test=\"slice-container\"]"
+    selector: '[data-test="slice-container"]'
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/exploring-data";
-    image_url: 
"https://superset.apache.org/img/tutorial/blue_bar_insert_component.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/exploring-data'
+    image_url: 
'https://superset.apache.org/img/tutorial/blue_bar_insert_component.png'
     output_path: docs/static/img/tutorial/blue_bar_insert_component.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/exploring-data.mdx
     app_path: null
     selector: null
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/exploring-data";
-    image_url: 
"https://superset.apache.org/img/tutorial/csv_to_database_configuration.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/exploring-data'
+    image_url: 
'https://superset.apache.org/img/tutorial/csv_to_database_configuration.png'
     output_path: docs/static/img/tutorial/csv_to_database_configuration.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/exploring-data.mdx
     app_path: null
     selector: null
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/exploring-data";
-    image_url: "https://superset.apache.org/img/tutorial/edit-record.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/exploring-data'
+    image_url: 'https://superset.apache.org/img/tutorial/edit-record.png'
     output_path: docs/static/img/tutorial/edit-record.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/exploring-data.mdx
     app_path: null
     selector: null
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/exploring-data";
-    image_url: "https://superset.apache.org/img/tutorial/edit_annotation.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/exploring-data'
+    image_url: 'https://superset.apache.org/img/tutorial/edit_annotation.png'
     output_path: docs/static/img/tutorial/edit_annotation.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/exploring-data.mdx
     app_path: null
     selector: .ant-modal-container
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/exploring-data";
-    image_url: "https://superset.apache.org/img/tutorial/markdown.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/exploring-data'
+    image_url: 'https://superset.apache.org/img/tutorial/markdown.png'
     output_path: docs/static/img/tutorial/markdown.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/exploring-data.mdx
     app_path: null
     selector: null
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/exploring-data";
-    image_url: 
"https://superset.apache.org/img/tutorial/no_filter_on_time_filter.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/exploring-data'
+    image_url: 
'https://superset.apache.org/img/tutorial/no_filter_on_time_filter.png'
     output_path: docs/static/img/tutorial/no_filter_on_time_filter.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/exploring-data.mdx
     app_path: null
     selector: null
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/exploring-data";
-    image_url: 
"https://superset.apache.org/img/tutorial/parse_dates_column.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/exploring-data'
+    image_url: 
'https://superset.apache.org/img/tutorial/parse_dates_column.png'
     output_path: docs/static/img/tutorial/parse_dates_column.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/exploring-data.mdx
     app_path: null
     selector: null
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/exploring-data";
-    image_url: "https://superset.apache.org/img/tutorial/publish_dashboard.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/exploring-data'
+    image_url: 'https://superset.apache.org/img/tutorial/publish_dashboard.png'
     output_path: docs/static/img/tutorial/publish_dashboard.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/exploring-data.mdx
     app_path: null
-    selector: "[data-test=\"dashboard-header-container\"]"
+    selector: '[data-test="dashboard-header-container"]'
   - type: tutorial
-    page_url: 
"https://superset.apache.org/user-docs/using-superset/exploring-data";
-    image_url: "https://superset.apache.org/img/tutorial/resample.png";
+    page_url: 
'https://superset.apache.org/user-docs/using-superset/exploring-data'
+    image_url: 'https://superset.apache.org/img/tutorial/resample.png'
     output_path: docs/static/img/tutorial/resample.png
-    alt: ""
+    alt: ''
     source_file: docs/using-superset/exploring-data.mdx

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>Invalid source file paths</b></div>
   <div id="fix">
   
   All 37 `source_file` entries reference `docs/using-superset/*.mdx` which 
does not exist. Actual files are at `docs/docs/using-superset/*.mdx`. The 
screenshot generator will fail when attempting to update markdown references. 
([Rule 10612](https://bito.ai/rules/10612))
   </div>
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #bf818d</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a 
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org