aminghadersohi commented on PR #42490: URL: https://github.com/apache/superset/pull/42490#issuecomment-5119200359
Addressed the review feedback in `79f6d02628`: - cached `TEMPORAL_RANGE` bindings are replaced when an update selects a different temporal column, while unrelated adhoc filters remain intact - explicit non-temporal `temporal_column` values now fail dataset validation with `NON_TEMPORAL_COLUMN` and actionable guidance - added focused regression coverage for both transitions - expanded explicit temporal/non-temporal mapper coverage to `BigNumberChartConfig` Validation: - `55 passed` across the dashboard time-binding and update-preview unit suites - `ruff-format`, `ruff`, and `mypy` passed for changed files - `pre-commit run --all-files` was also attempted; Python checks including mypy passed, but the full run is environment-blocked by missing frontend/Helm tooling and read-only npm/cache paths (and it reports unrelated existing all-files ruff findings). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
