aminghadersohi commented on PR #42490: URL: https://github.com/apache/superset/pull/42490#issuecomment-5121847835
Addressed the remaining review finding in `db58820780` after tracing all three binding candidates (explicit `temporal_column`, mapper `granularity_sqla`, and dataset fallback): - explicit `temporal_column` is resolved first, so a temporal XY or mixed-timeseries granularity can no longer suppress a different explicitly requested dashboard binding - `granularity_sqla` only short-circuits dashboard binding after `is_column_truly_temporal` verifies the column - a categorical Waterfall `x_axis` paired with `time_grain` therefore no longer appears bound merely because the mapper populated `granularity_sqla`; it falls back to the dataset `main_dttm_col` - the existing same-subject deduplication in `_ensure_temporal_adhoc_filter` remains intact, avoiding duplicate bindings Regression coverage includes: 1. explicit `created_at` overriding temporal `event_time` granularity for both XY and mixed-timeseries configs 2. categorical Waterfall granularity falling back to dataset `order_date` Validation: - changed-file pre-commit suite passes: mypy, ruff-format, ruff, pylint, and all applicable hooks - required `pre-commit run --all-files` executed; mypy and repository metadata checks passed, with the full run still limited by unavailable frontend/Helm dependencies and unrelated all-files ruff findings in this environment - local pytest collection remains blocked because the installed `sqlglot` lacks `sqlglot.dialects.singlestore`; CI has been triggered for the pushed commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
