aminghadersohi commented on PR #42490: URL: https://github.com/apache/superset/pull/42490#issuecomment-5119393172
Addressed the two new review comments in `abfb554720`: - explicit temporal-column binding is no longer suppressed by an existing `TEMPORAL_RANGE` filter for a different subject - stale cached temporal filters are removed when a new mapping has no valid temporal subject - unrelated/chart-specific filters remain preserved - added regression tests for both cases Validation: `57 passed`; changed-file `ruff-format`, `ruff`, and `mypy` all pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
