aminghadersohi commented on PR #42490: URL: https://github.com/apache/superset/pull/42490#issuecomment-5134716183
CI fix pushed in `79931ade17`. Root cause: the failing test encoded the correct contract. `map_xy_config` eagerly added a neutral `TEMPORAL_RANGE` for the temporal x-axis (`event_time`), then the shared binder correctly added the explicit `temporal_column` (`created_at`). That left two dashboard-range subjects, defeating explicit-column precedence. I fixed production code rather than weakening the assertion: when `temporal_column` is explicit, the XY mapper defers temporal-filter creation to the shared binder. The existing x-axis binding behavior is unchanged when no explicit column is supplied. Local verification (using a clean requirements-matching `sqlglot==30.12.0` target because the preinstalled package was incomplete): - `pytest -q tests/unit_tests/mcp_service/chart/test_dashboard_time_binding.py` → `32 passed` - the two reviewer regression cases plus the Waterfall fallback case → `3 passed` - changed-file pre-commit suite → all applicable hooks passed - required `pre-commit run --all-files` executed; Python mypy/pylint and metadata checks passed, with known environment-only frontend cache/tooling and unrelated all-files ruff limitations `test-postgres-hive` is independent: it failed before test execution because Docker could not bind namenode host port `50070` (`address already in use`). The new push has retriggered that job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
