rusackas commented on code in PR #41492:
URL: https://github.com/apache/superset/pull/41492#discussion_r3685633788
##########
superset/db_engine_specs/base.py:
##########
@@ -540,6 +540,15 @@ class BaseEngineSpec: # pylint:
disable=too-many-public-methods
arraysize = 0
max_column_name_length: int | None = None
+ # Characters used to quote identifiers (table/column names) that aren't
simple.
+ # Defaults to ANSI double quotes; dialects that differ override these —
e.g.
+ # MySQL/MariaDB use backticks and SQL Server uses square brackets. Embedded
+ # quote characters are escaped by doubling the closing character. These are
+ # surfaced to the client (see `get_public_information`) so identifier
quoting
+ # stays owned by the engine spec rather than duplicated per client.
+ identifier_quote_start: str = '"'
Review Comment:
Added backtick identifier_quote overrides on HiveEngineSpec and
DatabricksBaseEngineSpec (Spark SQL under the hood for both), plus tests
asserting the backticks.
##########
superset/sqllab/utils.py:
##########
@@ -41,6 +41,7 @@
"disable_data_preview",
"disable_drill_to_detail",
"allow_multi_catalog",
+ "engine_information",
Review Comment:
Added a unit test on bootstrap_sqllab_data directly, mocking a non-ANSI
database and asserting engine_information survives the DATABASE_KEYS allowlist.
Stopped short of a full /api/v1/sqllab/ endpoint test since that function is
the actual bridge, but holler if you'd rather have it at the API layer too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
