bito-code-review[bot] commented on code in PR #41492:
URL: https://github.com/apache/superset/pull/41492#discussion_r3667956563
##########
superset/databases/schemas.py:
##########
@@ -1165,6 +1165,15 @@ class DatabaseSchemaAccessForFileUploadResponse(Schema):
)
+class IdentifierQuoteSchema(Schema):
+ start = fields.String(
+ metadata={"description": "Character that opens a quoted identifier"}
+ )
+ end = fields.String(
+ metadata={"description": "Character that closes a quoted identifier"}
+ )
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing test coverage for new field</b></div>
<div id="fix">
Add test coverage for the new `identifier_quote` field (lines 1203-1208).
The existing test in `test_schemas.py` covers `supports_offset` but does not
verify `identifier_quote` serialization. Backend serialization in
`base.py:2671-2674` confirms the nested structure is provided, so a targeted
test assertion should be added following the established pattern in the file.
</div>
</div>
<small><i>Code Review Run #42966c</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
