rusackas commented on code in PR #41492:
URL: https://github.com/apache/superset/pull/41492#discussion_r3668125359
##########
superset/databases/schemas.py:
##########
@@ -1165,6 +1165,15 @@ class DatabaseSchemaAccessForFileUploadResponse(Schema):
)
+class IdentifierQuoteSchema(Schema):
+ start = fields.String(
+ metadata={"description": "Character that opens a quoted identifier"}
+ )
+ end = fields.String(
+ metadata={"description": "Character that closes a quoted identifier"}
+ )
Review Comment:
Good catch, added a dedicated test for `identifier_quote` in
`test_schemas.py`. It was already covered indirectly via the engine spec and
API tests, but wanted it asserted directly at the schema level too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
