bito-code-review[bot] commented on code in PR #37141:
URL: https://github.com/apache/superset/pull/37141#discussion_r3717522705
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -923,6 +965,36 @@ const DashboardBuilder = () => {
`}
/>
)}
+ {/* Mobile filters drawer */}
+ {!isNotMobile && nativeFiltersEnabled && (
Review Comment:
<!-- Bito Reply -->
The suggestion to add the `hasFilters` guard is appropriate. It ensures the
mobile filter drawer only mounts when filters are actually available,
maintaining consistency with the header button logic and preventing the display
of an empty, non-interactive UI panel.
**superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx**
```
{/* Mobile filters drawer */}
{!isNotMobile && nativeFiltersEnabled && hasFilters && (
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
