rusackas commented on code in PR #37141:
URL: https://github.com/apache/superset/pull/37141#discussion_r3718428526
##########
superset-frontend/src/dashboard/components/Header/useHeaderActionsDropdownMenu.tsx:
##########
@@ -357,11 +416,15 @@ export const useHeaderActionsMenu = ({
expandedSlices,
handleMenuClick,
isLoading,
+ isMobile,
+ isPublished,
+ isStarred,
lastModifiedTime,
layout,
onSave,
refreshFrequency,
reportMenuItem,
+ saveFaveStar,
Review Comment:
`saveFaveStar` isnt dead — its checked at line 231 inside this same `menu`
factory (`if (saveFaveStar) { ... }`), separate from its use in
`handleMenuClick`. Its correctly a dependency here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
