bito-code-review[bot] commented on code in PR #37141:
URL: https://github.com/apache/superset/pull/37141#discussion_r3718429637
##########
superset-frontend/src/dashboard/components/Header/useHeaderActionsDropdownMenu.tsx:
##########
@@ -357,11 +416,15 @@ export const useHeaderActionsMenu = ({
expandedSlices,
handleMenuClick,
isLoading,
+ isMobile,
+ isPublished,
+ isStarred,
lastModifiedTime,
layout,
onSave,
refreshFrequency,
reportMenuItem,
+ saveFaveStar,
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to remove `saveFaveStar` from the `useMemo`
dependency array is based on the observation that it is not used within the
`useMemo` callback body itself. Since `saveFaveStar` is indeed referenced
elsewhere in the factory function, keeping it in the dependency array is
correct if the `useMemo` result depends on its value, or if the intention is to
ensure the memoized value is recomputed whenever `saveFaveStar` changes. If the
memoized value does not actually depend on `saveFaveStar`, the dependency is
redundant.
**superset-frontend/src/dashboard/components/Header/useHeaderActionsDropdownMenu.tsx**
```
onSave,
refreshFrequency,
reportMenuItem,
saveFaveStar,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
