rusackas opened a new pull request, #42803: URL: https://github.com/apache/superset/pull/42803
### SUMMARY **Investigation only, do not merge.** Testing a full SQLAlchemy 2.0 + flask-sqlalchemy 3.1.1 bump directly, rather than the flask-sqlalchemy 3.0.5 intermediate step attempted and reverted in #42542. Cherry-picked from @mikebridge's `test/verify-sqlalchemy-continuum` branch (backend-relevant hunks only, dropped unrelated frontend formatting drift, restored the `sqlglot` lockfile line to current `master`'s version). One change beyond the version bumps worth flagging: `pessimistic_connection_handling` (`superset/utils/core.py`) now calls `connection.rollback()` after its pool-checkout health-check `SELECT`. Under SQLAlchemy 2.0's autobegin behavior, that `SELECT` implicitly opens a transaction the old code never closed. That's a plausible mechanism for the MySQL lock-wait-timeout symptom from the original #42542 break, separate from (and possibly more central than) the Flask-AppBuilder registry-mismatch theory tested and disproven in #42789. Also updates two migration scripts (`2018-07-26_..._add_implicit_tags`, `2022-04-01_..._new_dataset_models_take_2`) to `Mapped[]`-typed relationship annotations. Both define their own standalone declarative models and were missed by discussion #40273's earlier unit-test-driven deprecation-warning sweep, since migration scripts aren't exercised by that suite. Removes the now-obsolete `SQLALCHEMY_WARN_20` `pytest.ini` `filterwarnings` error lines, since `sqlalchemy.exc.RemovedIn20Warning` doesn't fire (or exist in the same form) once SQLAlchemy 2.0 is actually installed. Full context: discussion #40273, step 6. ### TESTING INSTRUCTIONS N/A, investigation only. Pushing to get a real `test-sqlite`/`test-mysql` CI signal, since local sqlite runs haven't reliably reproduced the original break either way. ### ADDITIONAL INFORMATION - [ ] Has associated issue - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
