bito-code-review[bot] commented on code in PR #42803:
URL: https://github.com/apache/superset/pull/42803#discussion_r3733089824
##########
superset-core/pyproject.toml:
##########
@@ -45,7 +45,7 @@ dependencies = [
"isodate>=0.7.0",
"pyarrow>=16.0.0",
"pydantic>=2.8.0",
- "sqlalchemy>=1.4.0,<2.0",
+ "sqlalchemy>=2.0.0,<2.1",
Review Comment:
<!-- Bito Reply -->
The suggestion to migrate `Query.get()` to `session.get(Model, id)` is
correct and appropriate. Upgrading to SQLAlchemy 2.0 deprecates the old
`Query.get()` method, and using `session.get()` is the recommended approach to
ensure compatibility and avoid warning noise in your logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
