bito-code-review[bot] commented on code in PR #42803:
URL: https://github.com/apache/superset/pull/42803#discussion_r3732935168
##########
superset-core/pyproject.toml:
##########
@@ -45,7 +45,7 @@ dependencies = [
"isodate>=0.7.0",
"pyarrow>=16.0.0",
"pydantic>=2.8.0",
- "sqlalchemy>=1.4.0,<2.0",
+ "sqlalchemy>=2.0.0,<2.1",
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>SQLAlchemy 2.0 Query.get() deprecation</b></div>
<div id="fix">
Upgrading SQLAlchemy to 2.0 introduces deprecation warnings from the 9
existing `Query.get()` calls in the codebase. While functional, these should be
migrated to `session.get(Model, id)` per SQLAlchemy 2.0 migration guidelines.
Consider addressing before release to prevent warning noise in logs.
</div>
</div>
<small><i>Code Review Run #64e76a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
