mikebridge commented on PR #42863: URL: https://github.com/apache/superset/pull/42863#issuecomment-5218312284
Addressed the launch-review migration findings in c2e8c381f9:\n\n- downgrade now removes only the predecessor index and retains backward-compatible DATETIME(6), avoiding irreversible audit-timestamp truncation\n- runtime model emits DATETIME(6) for both MySQL and MariaDB\n- added focused model/migration tests for MySQL, MariaDB, SQLite, upgrade, and data-preserving downgrade\n- verified upgrade/downgrade/re-upgrade on MySQL 8 with 10,000 pre-migration rows; downgrade retained all 10,002 rows and two timestamps one microsecond apart\n- full affected suite: 65 passed; full MySQL audit module: 22 passed; staged-file pre-commit passed\n\nThe PR description now documents the non-atomic MySQL DDL and intentional data-preserving schema asymmetry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
