mikebridge commented on PR #42863: URL: https://github.com/apache/superset/pull/42863#issuecomment-5218608739
Launch-review follow-up pushed in a37acd3d46:\n\n- corrected the model documentation to distinguish discardable provisional records from immutable retained outcomes\n- parameterized SQLAlchemy TypeEngine annotations\n- explicitly typed migration-test context-manager mocks\n- retained the private-helper assertion in the mixed-tie regression because it makes the pre-fix control deterministic; public behavior alone can pass depending on which tied row the database selects\n\nFresh verification remains 66/66 affected tests with changed-file pre-commit fully green. This commit is documentation/test typing only; the current-head re-ack request above still applies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
