mikebridge commented on PR #42863: URL: https://github.com/apache/superset/pull/42863#issuecomment-5218523239
Superseding my earlier note that the approval covered unchanged content: the Aug 7 commits added substantive migration behavior and the final predecessor-ambiguity fix, so a current-head re-ack is appropriate.\n\nRichard's tied-predecessor concern is addressed in d6a421174a. The lookup now examines the complete newest timestamp group semantically: mixed statuses are ambiguous and retain the current audit, while an all-blocked tied group remains eligible for suppression. A discriminating mixed blocked/failed regression test was added.\n\nFresh verification at d6a421174a:\n- complete affected suite: 66 passed\n- audit module: 23/23 on SQLite and 23/23 on MySQL 8\n- changed-file pre-commit: passed, including MyPy, Ruff, and Pylint\n\n@rusackas, when convenient, could you please re-ack the current head, including the DATETIME(6)/data-preserving downgrade commits and this ambiguity fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
