justinpark commented on code in PR #43093:
URL: https://github.com/apache/superset/pull/43093#discussion_r3797508248


##########
superset-frontend/packages/superset-core/src/chat/index.ts:
##########
@@ -151,6 +151,136 @@ export declare const onDidChangeDisplayMode: 
Event<DisplayMode>;
  */
 export declare const onDidResizePanel: Event<{ width: number }>;
 
-// TODO: client actions API — tool availability functions will be added here
-// once the client_actions SIP is finalized. The chat namespace is the
-// intended integration point between the two SIPs.
+/**
+ * A client-side (frontend) tool the chat agent can call — see the "Client
+ * MCP Tools" SIP. Unlike a backend/MCP-server tool, its handler runs in the
+ * browser and can read/mutate whatever is currently on screen (e.g. the
+ * Dashboard v2 canvas), so it works entirely off local state with no network
+ * round trip of its own.
+ *
+ * Contributed either by the host itself (built-in "core" tools) or by an
+ * extension via `mcpTools.url` in its extension.json — see that file's
+ * `getMyTools(chat)`-shaped default export.
+ */
+export interface McpTool {

Review Comment:
   sounds good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to