justinpark commented on PR #43093: URL: https://github.com/apache/superset/pull/43093#issuecomment-5321111037
Thanks @aminghadersohi, @michael-s-molina , and @villebro Here is the major changes on client tool api. Rename McpTool/McpToolsFormat/McpToolsFactory to ClientTool/ClientToolsFormat/ ClientToolsFactory across the ambient package, ChatProvider, ExtensionsLoader, and the chat extension. Replace extension.json's declarative mcpTools.url mechanism with direct chat.registerClientTool(s) calls, mirroring registerCommand/registerChat — extensions register tools as a normal side effect of their own module instead of a separate Module Federation expose the host pre-loads. ExtensionsLoader auto-prefixes an extension's own tool names with its extension id (same per-extension scoping already used for extensions.getContext()), so extensions no longer prefix manually. Remove the mcpTools field from extension.json's schema entirely (Python types, CLI, webpack template). Also fix extensions/chat's own webpack config, which used a plain `externals` global instead of a proper Module Federation shared singleton, silently bypassing this scoping. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
