justinpark commented on PR #43093: URL: https://github.com/apache/superset/pull/43093#issuecomment-5321221485
> SIP-214 §2.2 requires host/core to "remain independent of any specific LLM provider," and SIP-224 makes "Core never names a vendor" a hard rule (the vendor lives behind a pluggable provider seam). This PR puts McpToolsFormat.Claude and an Anthropic-shaped converter directly into @apache-superset/core and the host ChatProvider Fully agree with this point. I've been thinking about whether the conversion process — adapting a once-defined client tool to fit each vendor's specific format — should be handled inside the API itself or done externally. That's part of why the initial version was implemented with just mapping, avoiding external libraries as much as possible. The core handles it without any third-party vendor libraries, but I'm still weighing whether that's the right approach and whether it's truly necessary in the long run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
