EnxDev commented on code in PR #43296:
URL: https://github.com/apache/superset/pull/43296#discussion_r3846623474
##########
superset-frontend/src/explore/components/DataTablesPane/components/DataTableControls.tsx:
##########
@@ -111,14 +112,18 @@ export const TableControls = ({
value={rowLimit}
onChange={onRowLimitChange}
options={rowLimitOptions ?? []}
+ // Labelled as the applied limit to avoid a second row count next
to RowCountLabel.
+ prefix={t('Limit')}
css={css`
- min-width: 110px;
+ min-width: 160px;
`}
/>
)}
- {(!onRowLimitChange || rowcount < (rowLimit ?? Infinity)) && (
- <RowCountLabel rowcount={rowcount} loading={isLoading} />
- )}
+ <RowCountLabel
+ rowcount={rowcount}
+ limit={effectiveRowLimit ?? rowLimit}
Review Comment:
No, not intended — good catch. The Samples pane's row limit is just this
pane's own page-size selector, not a chart's row_limit, so showing "The row
limit set for the chart was reached. The chart may show partial data." there
was wrong copy. Fixed by adding an optional limitReachedMessage override on
RowCountLabel/TableControls; SamplesPane now supplies its own wording ("The
sample row limit was reached. This dataset may contain more rows.") instead of
the chart-specific message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
