msyavuz commented on code in PR #43296:
URL: https://github.com/apache/superset/pull/43296#discussion_r3861229733
##########
superset-frontend/src/explore/components/DataTablesPane/components/DataTableControls.tsx:
##########
@@ -111,14 +113,19 @@ export const TableControls = ({
value={rowLimit}
onChange={onRowLimitChange}
options={rowLimitOptions ?? []}
+ // Labelled as the applied limit to avoid a second row count next
to RowCountLabel.
+ prefix={t('Limit')}
css={css`
- min-width: 110px;
+ min-width: 160px;
`}
/>
)}
- {(!onRowLimitChange || rowcount < (rowLimit ?? Infinity)) && (
- <RowCountLabel rowcount={rowcount} loading={isLoading} />
- )}
+ <RowCountLabel
+ rowcount={rowcount}
+ limit={effectiveRowLimit ?? rowLimit}
Review Comment:
The mirror of the Samples case survives here: when the pane's own page size
(default 1000) is below the chart's `row_limit`, `effectiveRowLimit ===
rowLimit` and a full page still shows the chart copy on an untruncated chart —
e.g. `row_limit: 10000` returning 5000 rows with the pane at 1000. Should the
chart wording be gated on `effectiveRowLimit === chartRowLimit`?
`DataTableControls.test.tsx:57` currently locks the wrong copy in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
