bito-code-review[bot] commented on code in PR #43296:
URL: https://github.com/apache/superset/pull/43296#discussion_r3847727441
##########
superset-frontend/src/components/RowCountLabel/index.tsx:
##########
@@ -26,14 +26,23 @@ type RowCountLabelProps = {
limit?: number;
loading?: boolean;
label?: JSX.Element;
+ // Overrides the default "chart" wording for panes (e.g. samples) where the
+ // limit reached isn't the chart's own row_limit.
+ limitReachedMessage?: React.ReactNode;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing test for new prop</b></div>
<div id="fix">
The new `limitReachedMessage` prop lacks test coverage. Add a test that
renders `RowCountLabel` with `limitReachedMessage` and verifies the custom
message appears in the tooltip instead of the default translation. This aligns
with [adaptive rule 6262]: tests should verify actual business logic, not just
component rendering.
</div>
</div>
<small><i>Code Review Run #e28221</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
